Weaving for edit on github button#140
Weaving for edit on github button#140Jay-sanjay wants to merge 1 commit intoJuliaSmoothOptimizers:mainfrom
edit on github button#140Conversation
abelsiqueira
left a comment
abelsiqueira
left a comment
There was a problem hiding this comment.
Thanks for the PR, @Jay-sanjay. I made a change request to make it more efficient.
The preview won't work from this branch. Have you tested it? Do you have a preview built from your fork, maybe?
| write(tutorial_path, tutorial_content * footer) | ||
|
|
||
| # Weave the tutorial | ||
| weave(tutorial_path) |
There was a problem hiding this comment.
The tutorial is already woven when weave_folder is called above, so this is weaving twice, which is slow.
Instead, this footer can be added in weave_file. The original code came from SciML tutorials, and I think that is how they do it there.
There was a problem hiding this comment.
@Jay-sanjay, you marked this as resolved and re-requested a review. This is not resolved. Also, as you mentioned in your comment, the .md file doesn't have the "Edit this on Github", so your solution is apparently not working.
Let me know if you need some clarification, thanks.
|
Yes @abelsiqueira sir I did tried to build it as mentioned in the README using |
2 participants
This PR is related to - JuliaSmoothOptimizers/JuliaSmoothOptimizers.github.io#83